Add blockquote styling #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshot would be nice :) |
|
Thanks for the issue and the PR! My impulse would be to pick the same background color as pre tags to keep the noise down? Screenshots one or both ways would certainly help facilitate discussion. |
|
Let there be screenshots! My guess at a tint: Same background color as pre: |
|
The tinted one looks fine to me. Do others have thoughts or should we just merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #775
I guessed at a border color that fit with the purple theme and selected a lighter tint for the background.
As you can probably see from the padding rule I'm not very familiar with css, I'm not sure why the top padding was so hard to change but it was always much larger than the bottom padding. I also took a guess at the right padding so as to make it symmetrical with the left padding.
Feel free to suggest better colors or padding.