Add support for labeled module references #1315
Conversation
garetxe
force-pushed
the
labeledRefs
branch
2 times, most recently
from
c648295
to
e4b25c6
Compare
Support a markdown-style way of annotating module references. For instance
-- | [label]("Module.Name#anchor")
will create a link that points to the same place as the module
reference "Module.Name#anchor" but the text displayed on the link will
be "label".
|
Just to clarify: this was already merged in the |
|
@garetxe Any idea why we're hitting https://github.com/haskell/haddock/pull/1315/checks?check_run_id=1845591424#step:7:65 ? |
|
Yes, this should be fixed by 0fd9131 : the |
|
Alright now we're hitting |
|
There is still a failing test, but this is the same Bug873 as last time, due to the change on the interface version (see comments #1181 (comment) and #1296 (comment)). If I remove that test the tests pass locally for me. Please let me know if you would like me to add a commit removing that test from my branch. |
|
@garetxe This is also the symptom of something deeper. I have a call with Alex tomorrow and we'll decide of a solution. Otherwise, it's all good. I'll merge the PR when it's all green. :) |
|
OK, great, thanks a lot :) |
|
@garetxe Alright, I've had the call with @alexbiehl and we decided to make some changes to the PR to ensure backward compatibility. |
|
Great, thanks a lot! :) |
|
Oh, and I don't care about the authorship part, as long as the patch goes in in some form I am happy! |
Support a markdown-style way of annotating module references. For instance
-- | label
will create a link that points to the same place as the module
reference "Module.Name#anchor" but the text displayed on the link will
be "label".
(This is a rebase of #1181 for ghc-9.0, as requested in #1181 (comment))