Making setCache strict in it's first argument instead

haskell · Jun 21, 2019 · b7fb445 · b7fb445
1 parent 032d7d7
commit b7fb445
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/hie-plugin-api/Haskell/Ide/Engine/ModuleCache.hs b/hie-plugin-api/Haskell/Ide/Engine/ModuleCache.hs
@@ -1,4 +1,3 @@
-{-# LANGUAGE BangPatterns #-}
 {-# LANGUAGE RankNTypes #-}
 {-# LANGUAGE ScopedTypeVariables #-}
 {-# LANGUAGE FlexibleContexts #-}
@@ -54,8 +53,7 @@ import           Haskell.Ide.Engine.PluginsIdeMonads
 modifyCache :: (HasGhcModuleCache m) => (GhcModuleCache -> GhcModuleCache) -> m ()
 modifyCache f = do
   mc <- getModuleCache
-  let !cached = f mc -- Avoid a space leak by forcing the cache calculation
-  setModuleCache cached
+  setModuleCache (f mc)
 
 -- ---------------------------------------------------------------------
 -- | Runs an IdeM action with the given Cradle

diff --git a/hie-plugin-api/Haskell/Ide/Engine/PluginsIdeMonads.hs b/hie-plugin-api/Haskell/Ide/Engine/PluginsIdeMonads.hs
@@ -1,3 +1,4 @@
+{-# LANGUAGE BangPatterns #-}
 {-# LANGUAGE DeriveGeneric #-}
 {-# LANGUAGE DeriveFunctor #-}
 {-# LANGUAGE DeriveAnyClass #-}
@@ -499,7 +500,7 @@ instance HasGhcModuleCache IdeM where
     tvar <- lift ask
     state <- liftIO $ readTVarIO tvar
     return (moduleCache state)
-  setModuleCache mc = do
+  setModuleCache !mc = do
     tvar <- lift ask
     liftIO $ atomically $ modifyTVar' tvar (\st -> st { moduleCache = mc })