Release hls-1.0.0 to hackage #1470

jneira · 2021-03-01T09:26:44Z

We have to start the process to upload all packages in this repo to hackage
We bumped out all bounds in the last release so we could upload their versions at https://github.com/haskell/haskell-language-server/tree/1.0.0, without creating a dedicated branch and backport .cabal changes (so it will be easier this time i hope)
- imo we should not release other changes after 1.0.0
- so f.e. we should release the hls-hlint-plugin version with the bug (1.0.0.0) before upload 1.0.0.1
The order would be: hls-plugin-api -> ghcide and co -> plugins -> hls itself

jneira · 2021-03-02T22:19:26Z

wz1000 · 2021-03-02T22:23:19Z

Why do we need a hie-compat release? It hasn't changed at all.

jneira · 2021-03-03T14:31:35Z

In the last release we bumped up all packages versions to 1.0.0 and all deps bounds to 1.0.* for consistency, even if they did not change so the upload is needed

wz1000 · 2021-03-03T14:39:22Z

I don't think hie-compat needs to be at 1.0, I can revert that change if necessary. ghc-exactprintand hiedb were not bumped to 1.0 either, similarly hie-compat is more of a supporting library than a part of HLS.

jneira · 2021-03-03T22:34:38Z

Uploaded ghcide release candidate: https://hackage.haskell.org/package/ghcide-1.0.0.0/candidate

Ailrun · 2021-03-04T00:08:18Z

@jneira Oops, it still uses hie-compat >= 1.0.0.0

jneira · 2021-03-04T05:19:06Z

ugh did I forget to pull last changes? sure
will correct asap, thanks for check the candidate

jneira · 2021-03-04T05:25:43Z

@Ailrun corrected and uploaded again 🤞

Ailrun · 2021-03-04T07:31:06Z

Awesome, thanks!

jneira · 2021-03-04T08:32:59Z

ghcide fails due to the last version of haddock-library and the lack of upper bounds for it 😟

src\Development\IDE\Spans\Common.hs:123:28: error:
    • Couldn't match type ‘H.ModLink (H.DocH String String)’
                     with ‘[Char]’
      Expected type: String
        Actual type: H.ModLink (H.DocH String String)
    • In thehe first argument of ‘escapeBackticks’, namelymely ‘i’
      In the first argument of ‘(++)’, namelymely ‘escapeBackticks i’
      In the second argument of ‘(++)’, namelymely ‘escapeBackticks i ++ "`"’
    |
123 |   = "`" ++ escapeBackticks i ++ "`"
    |                            ^
cabal: Failed to build ghcide-0.6.0 (which is required by exe:ghcide-bench
from ghcide-0.6.0).

will open a pr for master and will backport in hls-1.0.0-hackage

jneira · 2021-03-04T08:37:53Z

Forgot to mention i did a hackage revision for ghcide-0.7.5, as it was failing for hls-plugin-api-1.0.0 and haddock-library: https://hackage.haskell.org/package/ghcide-0.7.5.0/revisions/

I assumed haddock-library was fixed in master

jneira · 2021-03-05T06:41:52Z

Pinging maintainers of each plugin: Release hls-1.0.0 to hackage #1470 (comment)
The hackage release should be done on the 1.0.0-hackage branch
- Theorically, it has the sorrect versions and bounds but a sanity check building the plugin in isolation againts ghcide and hls-plugin-api 1.0.0.0, already released, would be nice
- Possible changes in cabal files (no source files should be changed) should be done on master and backported to the branch (you can use mergifyio to backport changes auto)

jneira · 2021-03-05T06:45:46Z

@berberman maybe it would be handy if hls-haddock-comments-plugin could have some other hls maintainer(s). Feel free to add us, if anybody dont want to always can remove itself from the list 😄
@isovector same for hls-~~tactics~~wingman-plugin

isovector · 2021-03-05T06:49:17Z

@jneira I'd like to backport #1454, but don't know how to do that.

jneira · 2021-03-05T06:51:51Z

@isovector #1454 (comment) should work, i hope (good move @Ailrun 😄 )

it did! #1500

isovector · 2021-03-05T06:54:01Z

Thanks!

berberman · 2021-03-05T07:39:07Z

@jneira I uploaded hls-haddock-comments-plugin and added other maintainers.

isovector · 2021-03-05T07:47:00Z

@jneira I've uploaded hls-tactics-plugin, and added @alanz @pepeiborra @Ailrun, @wz1000 and @jneira as maintainers.

Ailrun · 2021-03-05T18:13:09Z

hls-class-plugin is uploaded.

pepeiborra · 2021-03-06T11:01:21Z

Uploaded hls-explicit-imports-plugin and hls-retrie-plugin

jneira · 2021-03-06T20:20:02Z

Uploaded hls-hlint-plugin-1.0.0.1: https://hackage.haskell.org/package/hls-hlint-plugin-1.0.0.1

jneira · 2021-03-06T21:08:03Z

Uploaded hls-splice-plugin-1.0.0.0: https://hackage.haskell.org/package/hls-splice-plugin-1.0.0.0

jneira · 2021-03-06T21:11:31Z

@tittoassini hi! hls-eval-plugin is the last plugin required to upload hls itself
It would be great if you could add some other hls maintainer to the list of package maintainers, to agilize the release process 🙂

tittoassini · 2021-03-07T12:58:54Z

Hi @jneira, I have added you as hackage maintainer of the hls-eval-plugin . I will upload the package to hackage shortly. Il giorno sab 6 mar 2021 alle ore 22:11 Javier Neira < notifications@github.com> ha scritto:

…

@tittoassini <https://github.com/tittoassini> hi! hls-eval-plugin is the last plugin required to upload hls itself It would be great if you could add some other hls maintainer to the list of package maintainers, to agilize the release process 🙂 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1470 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFRQIAE422V7VGDQF7DCLTCKLA5ANCNFSM4YMG7MOQ> .

-- Pasqualino "Titto" Assini http://networkpolitics.svbtle.com http://quid2.org/

tittoassini · 2021-03-07T13:56:14Z

Hi @jneira, I have uploaded https://hackage.haskell.org/package/hls-eval-plugin-1.0.0.0 Il giorno dom 7 mar 2021 alle ore 13:58 Pasqualino "Titto" Assini < tittoassini@gmail.com> ha scritto:

…

Hi @jneira, I have added you as hackage maintainer of the hls-eval-plugin . I will upload the package to hackage shortly. Il giorno sab 6 mar 2021 alle ore 22:11 Javier Neira < ***@***.***> ha scritto: > @tittoassini <https://github.com/tittoassini> hi! hls-eval-plugin is the > last plugin required to upload hls itself > It would be great if you could add some other hls maintainer to the list > of package maintainers, to agilize the release process 🙂 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#1470 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAFRQIAE422V7VGDQF7DCLTCKLA5ANCNFSM4YMG7MOQ> > . > -- Pasqualino "Titto" Assini http://networkpolitics.svbtle.com http://quid2.org/

-- Pasqualino "Titto" Assini http://networkpolitics.svbtle.com http://quid2.org/

jneira · 2021-03-07T14:00:49Z

@tittoassini many thanks, the release is almost complete now

jneira · 2021-03-07T20:17:38Z

...and haskell-language-server-1.0.0.0 itself has been released after fixing a problem in its cabal file with 4c80cb3
~~will forward port to master~~it already was corrected in master

jneira mentioned this issue Mar 1, 2021

Bump up hlint plugin version #1469

Merged

cdepillabout mentioned this issue Mar 2, 2021

haskellPackages.haskell-language-server: 0.8.0 -> 0.9.0 NixOS/nixpkgs#112409

Merged

10 tasks

jneira added CI Continuous integration old_type: meta Planing and organizing other issues labels Mar 2, 2021

jneira mentioned this issue Mar 4, 2021

Haddock upper bound #1492

Merged

jneira closed this as completed Mar 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release hls-1.0.0 to hackage #1470

Release hls-1.0.0 to hackage #1470

jneira commented Mar 1, 2021 •

edited

jneira commented Mar 2, 2021 •

edited

wz1000 commented Mar 2, 2021

jneira commented Mar 3, 2021

wz1000 commented Mar 3, 2021

jneira commented Mar 3, 2021

Ailrun commented Mar 4, 2021 •

edited

jneira commented Mar 4, 2021

jneira commented Mar 4, 2021

Ailrun commented Mar 4, 2021

jneira commented Mar 4, 2021

jneira commented Mar 4, 2021

jneira commented Mar 5, 2021 •

edited

jneira commented Mar 5, 2021 •

edited

isovector commented Mar 5, 2021

jneira commented Mar 5, 2021 •

edited

isovector commented Mar 5, 2021

berberman commented Mar 5, 2021

isovector commented Mar 5, 2021 •

edited

Ailrun commented Mar 5, 2021

pepeiborra commented Mar 6, 2021

jneira commented Mar 6, 2021

jneira commented Mar 6, 2021

jneira commented Mar 6, 2021

tittoassini commented Mar 7, 2021 via email

tittoassini commented Mar 7, 2021 via email

jneira commented Mar 7, 2021

jneira commented Mar 7, 2021 •

edited

Release hls-1.0.0 to hackage #1470

Release hls-1.0.0 to hackage #1470

Comments

jneira commented Mar 1, 2021 • edited

jneira commented Mar 2, 2021 • edited

wz1000 commented Mar 2, 2021

jneira commented Mar 3, 2021

wz1000 commented Mar 3, 2021

jneira commented Mar 3, 2021

Ailrun commented Mar 4, 2021 • edited

jneira commented Mar 4, 2021

jneira commented Mar 4, 2021

Ailrun commented Mar 4, 2021

jneira commented Mar 4, 2021

jneira commented Mar 4, 2021

jneira commented Mar 5, 2021 • edited

jneira commented Mar 5, 2021 • edited

isovector commented Mar 5, 2021

jneira commented Mar 5, 2021 • edited

isovector commented Mar 5, 2021

berberman commented Mar 5, 2021

isovector commented Mar 5, 2021 • edited

Ailrun commented Mar 5, 2021

pepeiborra commented Mar 6, 2021

jneira commented Mar 6, 2021

jneira commented Mar 6, 2021

jneira commented Mar 6, 2021

tittoassini commented Mar 7, 2021 via email

tittoassini commented Mar 7, 2021 via email

jneira commented Mar 7, 2021

jneira commented Mar 7, 2021 • edited

jneira commented Mar 1, 2021 •

edited

jneira commented Mar 2, 2021 •

edited

Ailrun commented Mar 4, 2021 •

edited

jneira commented Mar 5, 2021 •

edited

jneira commented Mar 5, 2021 •

edited

jneira commented Mar 5, 2021 •

edited

isovector commented Mar 5, 2021 •

edited

jneira commented Mar 7, 2021 •

edited