Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghcide: ExceptionTests are incorrect #4036

Closed
fendor opened this issue Feb 2, 2024 · 1 comment · Fixed by #4146
Closed

Ghcide: ExceptionTests are incorrect #4036

fendor opened this issue Feb 2, 2024 · 1 comment · Fixed by #4146
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@fendor
Copy link
Collaborator

fendor commented Feb 2, 2024

All exception tests are run in the ghcide directory, inferring a cabal cradle and failing, as the test files are not part of ghcide.
The tests themselves do not actually test what they set out to and merely increase the test suite execution time.
@fendor fendor added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. status: needs triage component: ghcide and removed status: needs triage labels Feb 2, 2024
@fendor
Copy link
Collaborator Author

fendor commented Feb 2, 2024

This issue shows that we should unify the test util infrastructure of ghcide and plugins.

@fendor fendor mentioned this issue Mar 11, 2024
Closed
@fendor fendor mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run ExceptionTests in temporary directory fendor/haskell-language-server
1 participant
@fendor