Fix references to old names

[fendor]

See https://github.com/haskell/haskell-language-server/blob/master/haskell-language-server.cabal#L1821

[fendor]

Genuine test suite bugs uncovered :)

[michaelpj]

How did this not just break before??

[jhrcek]

Isn't this due to the default CPP behavior which is that it evaluates a symbol to false if it's not defined?

I didn't find where this behavior is described, but you can see it behaves like this in this example:

$ cat Main.hs
{-# LANGUAGE CPP #-}
#if hello
main = putStrLn "hello is on"
#else
main = putStrLn "hello is off"
#endif

$ ghc Main.hs
[1 of 2] Compiling Main             ( Main.hs, Main.o )
[2 of 2] Linking Main

$ ./Main
hello is off

[michaelpj]

The horror 😱

[fendor]

A lot of our tests are running (or not running) but failing or not failing for the wrong reasons, also see #4130 and #4036.

[fendor]

This Pr is superseded by the work of @jhrcek, closing.