Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ExceptionTests in temporary directory #4146

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Mar 22, 2024

Fixes #4036

The tests weren't strictly speaking incorrect, as they were testing what they aim to, but using the cabal directory of ghcide is not correct.

@fendor fendor requested a review from pepeiborra as a code owner March 22, 2024 16:57
@soulomoon soulomoon self-requested a review March 23, 2024 13:23
Copy link
Collaborator

@soulomoon soulomoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fendor fendor merged commit e9ee544 into haskell:master Mar 23, 2024
38 checks passed
soulomoon pushed a commit to soulomoon/haskell-language-server that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghcide: ExceptionTests are incorrect
2 participants