Test apply-refact with TypeApplications #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
force-pushed
the
test-hlint-typeapp
branch
from
e728002
to
60e7690
Compare
|
Hm? It passes all tests? |
|
@Ailrun yeah, i expected it, as it passes locally with master for me. But it failed in the past and |
Ailrun
approved these changes
Jan 22, 2021
|
|
||
| expectedTypeApp = [ "module ApplyRefact1 where", "" | ||
| , "a = id @Int 1" | ||
| ] |
There was a problem hiding this comment.
Maybe change these tests to golden tests? If it sounds good, I'm willing to update it.
There was a problem hiding this comment.
yeah, i was thinking in do it in the past. But otoh i suspect they will not change frequently and to have them close to the code has its value imo.
that said we are using golden tests in other tests and to be consistent is good too, so that change will welcomed, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_#1242 and test a "problematic" extension