Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license for hls-tactics-plugin #1248

Merged
merged 4 commits into from
Jan 23, 2021
Merged

Add license for hls-tactics-plugin #1248

merged 4 commits into from
Jan 23, 2021

Conversation

isovector
Copy link
Collaborator

No description provided.

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you also add the homepage and bug tracker?

@isovector
Copy link
Collaborator Author

TBH this is not currently a high priority to me. This PR was simply necessary to upload the package and it seemed a shame to have the two be out of sync.

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Jan 22, 2021
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's merge this then.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr and for uploading the package to hackage: https://hackage.haskell.org/package/hls-tactics-plugin
The rest of fields could be added in a follow up if you consider (and edit the package metadata with a revision)
Btw, have you think in adding some other maintainer to agilize the process of uploads and changes in the future?

@mergify mergify bot merged commit fdb8e5d into master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants