Refactor the hypothesis type in hls-tactics-plugin #1347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Hypothesis
is all of the values in scope that the tactics engine knows about. It used to be aMap OccName HyInfo
, mapping names to the information we have about them. But this is unhelpful for two reasons:Worse, it actively encouraged a bad style where we'd iterate through the keys of the hypothesis, and then need to look up the value in the map we were iterating. All of these callsites have now been simplified to just take the
HyInfo
directly, rather than anOccName
that we'd subsequently need to lookup.This PR refactors some of the underlying machinery. It's a bit simplistic now, but paves the way for a smarter implementation when I figure out what it should look like. In the meantime, it means we can now solve goals like
since the fmaps for
f
andg
no longer clash.