Decrease Wingman timeout from 3.3 minutes to 2 seconds (configurable) #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why 2 seconds though. Seems a bit short. Make it configurable ? |
isovector
changed the title
|
Now officially configurable! |
Ailrun
approved these changes
Apr 7, 2021
| -- semigroup | ||
| , "sconcat", "stimes" | ||
| -- monoid | ||
| , "mconcat" |
There was a problem hiding this comment.
Why are these changes bundled together?
There was a problem hiding this comment.
I'm an absolute madman
|
My rule is always make timeouts in seconds, and Double (or even better, the Seconds alias https://hackage.haskell.org/package/extra-1.7.9/docs/Extra.html#t:Seconds). Then also use the timeout from Extra (https://hackage.haskell.org/package/extra-1.7.9/docs/Extra.html#v:timeout) and everything works properly. Having timeouts in milliseconds, microseconds or whatever is just too confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point I made a boneheaded move, thinking that
1e8was the number of microseconds in a second. I'm not sure where this number came from, but it's 2 orders of magnitude too large. As a result, the timeout feature in Wingman didn't work very well.This PR changes the tactic timeout to be a more reasonable 2 seconds, down from 3+ minutes.