Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin nix-pre-commit-hooks #1780

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Pin nix-pre-commit-hooks #1780

merged 1 commit into from
Apr 30, 2021

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented Apr 29, 2021

This PR supersede #1779.

Fixes this GitHub nix action issue:

error: attribute 'run' missing, at /Users/runner/work/haskell-language-server/haskell-language-server/nix/default.nix:83:24
(use '--show-trace' to show detailed location information)
Error: Process completed with exit code 1.

@Ailrun Ailrun requested a review from pepeiborra April 29, 2021 19:41
pepeiborra
pepeiborra approved these changes Apr 29, 2021
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pepeiborra pepeiborra mentioned this pull request Apr 29, 2021
Closed
@Ailrun Ailrun added the merge me Label to trigger pull request merge label Apr 29, 2021
@mergify mergify bot merged commit 6bd6cf0 into haskell:master Apr 30, 2021
@Ailrun
Copy link
Member Author

Ailrun commented May 5, 2021

@Mergifyio backport 1.1.0-hackage

mergify bot pushed a commit that referenced this pull request May 5, 2021
@Ailrun
Pin nix-pre-commit-hooks (#1780)
deffb33 
(cherry picked from commit 6bd6cf0)
@mergify mergify bot mentioned this pull request May 5, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented May 5, 2021

Command backport 1.1.0-hackage: success

Backports have been created

@Ailrun
Copy link
Member Author

Ailrun commented May 5, 2021

CI on 1.1.0-hackage keeps failing because of this, so it'd be better to backport this.

jneira pushed a commit that referenced this pull request May 5, 2021
@mergify @Ailrun
Pin nix-pre-commit-hooks (#1780) (#1798)
1b3868a 
(cherry picked from commit 6bd6cf0)

Co-authored-by: Junyoung/Clare Jang <jjc9310@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ailrun @pepeiborra