Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.2.0 June release #1912

Merged
merged 10 commits into from
Jun 12, 2021
Merged

Prepare 1.2.0 June release #1912

merged 10 commits into from
Jun 12, 2021

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented Jun 11, 2021

Resolves partially #1890

ChangeLog.md Outdated Show resolved Hide resolved
ChangeLog.md Outdated Show resolved Hide resolved
ChangeLog.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@isovector isovector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pepeiborra
Copy link
Collaborator

Should bump the versions of ghcide, hls-graph and his-plugin-api as well in preparation for the Hackage upload?

@Ailrun
Copy link
Member Author

Ailrun commented Jun 11, 2021

@pepeiborra Oh, right. I will bump those too.

Copy link
Collaborator

@berberman berberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think we should bump hls-brittany-plugin to 1.0.0.2

@@ -48,7 +48,7 @@ library
, extra
, filepath
, ghc-exactprint >=0.6.3.4
, ghcide >=1.2 && <1.4
, ghcide ^>=1.4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes because hlint plugin probably won't work with ghcide <= 1.3 after #1862

@Ailrun Ailrun merged commit 7d7c2ef into haskell:master Jun 12, 2021
@hasufell
Copy link
Member

I don't see the .tar.gz files that are usually used by ghcup.

@Ailrun
Copy link
Member Author

Ailrun commented Jun 12, 2021

@hasufell It's not yet built. It will be built after all other version-specific .gz files are done.

@hasufell
Copy link
Member

@Ailrun
Copy link
Member Author

Ailrun commented Jun 13, 2021

Yes, I'm resolving the issue.

@hasufell
Copy link
Member

Also... since ghcup now supports windows too, we'd need a .tar.gz for windows as well.

@Ailrun
Copy link
Member Author

Ailrun commented Jun 13, 2021

@hasufell Ah... true. @jneira Could you generate it manually? I will add a CI entry.

@jneira
Copy link
Member

jneira commented Jun 13, 2021

sure, will do this night gmt

@jneira
Copy link
Member

jneira commented Jun 13, 2021

As usual i have to generate manually the version for 8.8.4 (#276), the only one we support for windows and it will take some time in my poor laptop

@anka-213
Copy link
Contributor

Should we add the ghc-9.0 build as well to the release, so users doesn't have to build manually from source to get the basic ghc-9.0 support? Or is it to late now?

@jneira
Copy link
Member

jneira commented Jun 17, 2021

It is a good idea, if the executable can be used without tweaking too much configuration. A note should be added in the release, with a warning for the limited support and linking to the list of working components.
Not sure if we should change the file name to signal it is experimental and with limited support and avoid its automatic download by the vscode extension.
As stated in the new release doc version we can add new artifacts but no update old ones.

@anka-213
Copy link
Contributor

No, there shouldn't be much configuration tweaking needed. Adding the flag --cabal-project=cabal-ghc901.project or copying the cabal-ghc901.project to cabal.project should be all that's needed.

I don't think disabling automatic download should be needed, as long as it is clear to the user that it is experimental, since partial support is better than no support at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants