Wingman: Config option to suppress proofstate styling #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isovector
commented
Jun 22, 2021
| ] | ||
| properties = emptyProperties | ||
| & defineBooleanProperty #proofstate_styling |
There was a problem hiding this comment.
@berberman it's a little annoying that these properties need to be added in the opposite order as in the type. Is there a better pattern here?
There was a problem hiding this comment.
Hmm I think the order only affects the type signature of properties, no?
There was a problem hiding this comment.
Yes, but in the opposite order in which they're defined. Notice that I'm adding to the top of emptyProperties here, but the resulting type is added to the end of the type :(
isovector
force-pushed
the
suppress-proofstate-html
branch
from
90f5134
to
6c93d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1965