Remove HIE_CACHE from circleci cache key #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in haskell/haskell-ide-engine#968 (comment) I think it is better to make explicit the invalidation with a commit, to make clear in the commit history when it was done
|
As this will invalidate the cache for all prs, it will better wait to merge the ready ones |
jneira
changed the title
|
I think it's better to merge this after this release, as I will prepare the release in a few hours. |
Sure, this can wait Hey it will continue being July release for one day 😄 |
lukel97
approved these changes
Jul 29, 2021
Ailrun
approved these changes
Jul 30, 2021
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in haskell/haskell-ide-engine#968 (comment)
I think it is better to make explicit the invalidation with a commit, to make clear in the commit history when it was done
Will delete the env var from circleci config once this is merged