Semiautomatic hackage releases

[jneira]

• This try to make hackage releases as smooth as possible, hopefully fixes Automate hackage releases #1310
• It is dumb about changes: if some file (module obvious exclusions like docs files) has changed, we have to bomp up the version or it will fail
• It builds all packages for three last ghc major versions so it will take some time (with cold cache)
• It upload package candidates, a human should confirm the definitive release (ahopefully fter some manual checks)
• It depends on Remove ghc-api source snapshot #2156 to avoid errors about ghc-api-compat
• It is failing for hls-call-hierarchy-plugin:

[July541]

It is caused by aeson's Value, Value support Ord instance after their 1.5.2.0.

I checked your test and found it uses 1.4.7.1...

I think to add a lower bound for aeson in hls-call-hierarchy-plugin is enough (Maybe you can add it directly, I don't know how to participate in this thread..)

[jneira]

I think to add a lower bound for aeson in hls-call-hierarchy-plugin is enough (Maybe you can add it directly, I don't know how to participate in this thread..)

dont worry, the diagnostic is the "hard" part, will add the bound here, thanks!

[pepeiborra]

These are only needed to build the benchmark suite of ghcide. The benchmark suite is not a requirement for uploading to Hackage imho, and should be skipped

[jneira]

ya, but to use a simple autogenerated cabal.project with packages: . ../../* ../../plugins/* cabal has to find a build plan for shake-bench. The alternative is a cabal project listing explicitly all packages but shake-bench.
Otoh in theory you should be able to run the benchmarks (like tests) with the hackage version too, and ideally those allow-newer should be removed to allow it

[pepeiborra]

Suggested change

	cabal build --enable-tests --enable-benchmarks
	cabal build --enable-tests

[jneira]

ideally benchmarks should be able to run using the hackage version

[pepeiborra]

Nice job, this is going to be super useful

[pepeiborra]

Next step would be integrating @kowainik Policeman to validate the updated version numbers: https://kowainik.github.io/projects/policeman

[jneira]

Next step would be integrating @kowainik Policeman to validate the updated version numbers: https://kowainik.github.io/projects/policeman

wow, i had forgotten it, it would be really nice, will open an issue after merging this

[jneira]

I've used a hackage token generated from my account, it can be changed in the project secrets
However i have not perms to upload to all packages involved, missing are:

• https://hackage.haskell.org/package/shake-bench
• https://hackage.haskell.org/package/hie-compat
• https://hackage.haskell.org/package/hls-graph
• https://hackage.haskell.org/package/hls-ormolu-plugin
• https://hackage.haskell.org/package/hls-module-name-plugin
• https://hackage.haskell.org/package/hls-refine-imports-plugin
• https://hackage.haskell.org/package/hls-call-hierarchy-plugin, it is not uploaded (the script will do)

Most of them have @pepeiborra as unique maitainer so an option could be that @pepeiborra generates a hackage api key (i would create a new, dedicated, one). But even doing that i would add some more maintainers to those plugin with only one parent 😉

EDIT: resolved with a new token with full access, thanks @pepeiborra!

[pepeiborra]

I have added you to the maintainers list for all of them

[jneira]

Ok the workflow has failed in the last step, cause i did not put the hackage api key:

https://github.com/jneira/haskell-language-server/actions/runs/1208936609

Run haskell-actions/hackage-publish@v1
  with:
    packagesPath: packages
    publish: false
    hackageServer: http://hackage.haskell.org
Uploading hls-module-name-plugin-1.0.0.1 to http://hackage.haskell.org/packages/candidates
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  7777    0     0  100  7777      0  42037 --:--:-- --:--:-- --:--:-- 42037
curl: (22) The requested URL returned error: 401 Unauthorized
Error: Process completed with exit code 22.

I think the deinitive test can be done with the next release

[pepeiborra]

It would be nice to back port this to the 1.3.0-hackage branch and use it for the Hackage upload

[jneira]

I was waiting for the automatic backport, but CI is quite slow lately, will backport manually

[jneira]

backported with 97003e2
ci running in https://github.com/haskell/haskell-language-server/actions/runs/1212661332

[jneira]

As the workflow will take ages to start i've started it in my repo: https://github.com/jneira/haskell-language-server/runs/3545669772