[skip circleci] Add option to effectively cancel prev runs #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jneira
commented
Oct 29, 2021
•
jneira
commented
- Without using skip-duplicate-actions which is failing due to github access permission.
- See Warning: Failed to cancel https://github.com/pingcap/dm/actions/runs/766226952 fkirc/skip-duplicate-actions#103 and https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#concurrency
- We can keep skip-duplicate-actions, as it is cancelling and skipping using other criteria. But i suspect it can only cancel others if the branch source of the pr belongs to this repo
Without using skip-duplicate-actions which is failing due to github access permission. See fkirc/skip-duplicate-actions#103
jneira
changed the title
|
https://github.com/pingcap/dm/pull/1935/files this is our repo's modification, for your reference |
oh, i see, now it will cancel another workflows for the same branch, many many thanks |
Without it will cancel other workflows for the same branch Credits: 7b371e8b
jneira
changed the title
|
@lance6716 dont want to abuse, but i see the workflow you changed was skipping the job if the pr modified the README.md, did you replace that with another way to do it? |
currently we can't skip jobs for only modifying README.md 😂 that didn't happen too often. |
michaelpj
approved these changes
Oct 30, 2021
|
We are gonna [skip circleci] |
pepeiborra
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Add option to cancel prev runs Without using skip-duplicate-actions which is failing due to github access permission. See fkirc/skip-duplicate-actions#103 * Cancel by branch *and* workflow Without it will cancel other workflows for the same branch Credits: 7b371e8b * Disable cancelling other runs Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.