Caching process update #2467
Merged
Caching process update #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
force-pushed
the
2021-12-11-ci-upd-caching
branch
from
475c280
to
820d737
Compare
Hopefully it would remove it & its files from being cached in the action. & also not includde into environment.
For future caching configuraiton.
For 1:1 according cache to it.
Sources are stored separately. Before this cache was storing per Platform/GHC sources & compiled results together. While deps sources does not depend on platform or GHC, they are platform & GHC agnostic. Because sources & compiled results were stored togather & sources took ~1/2-2/3 of that - cache stored multiple duplicates of the same source code. This config stores the source code separately. And at the same time tries to store & share all source code which may be needed. & all compiled deps that would be used in different workflows.
Anton-Latukha
force-pushed
the
2021-12-11-ci-upd-caching
branch
2 times, most recently
from
9ac4c4a
to
284e203
Compare
|
[skip circleci] |
Anton-Latukha
force-pushed
the
2021-12-11-ci-upd-caching
branch
from
284e203
to
ff41e51
Compare
Anton-Latukha
force-pushed
the
2021-12-11-ci-upd-caching
branch
2 times, most recently
from
3098f20
to
f97b4bd
Compare
|
This PR has WIP commits that allow development & review. To not merge the work commits. Please, it needs to be reviewed as a draft, before being marked available for merge. |
jneira
reviewed
Dec 11, 2021
|
Ok. The working results in the PR are in: https://github.com/haskell/haskell-language-server/pull/2467/checks?sha=f97b4bd8794ac9e6ac4121b7cfed8ca92cce08c0 Now cleaning-up the PR from PR-work commits. |
Anton-Latukha
force-pushed
the
2021-12-11-ci-upd-caching
branch
from
f97b4bd
to
6483d96
Compare
jneira
approved these changes
Dec 12, 2021
|
Nice. After merge, it works as expected. Caching in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New code included & shares all source code that may be needed.
New config includes & shares all compiled deps that may be needed in workflows.
New config stores the source code separately, which means it gets stored one time.
Before this cache stored per Platform/GHC - the sources & compiled results
together. It is while sources not depend on platform or GHC, as sources are
platform & GHC agnostic. Because they were always bundled together
& sources took ~1/2-2/3 of that storage - cache stored multiple duplicates of the same
source code.
cachingworkflow now downloads, builds & shares all sources & all dependencies for all targets.dist-newstyleso far is not included in to the cache, (what to cache from them can be looked into in the next updates).