CI: caching: closer match work/CI guarantees #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
reviewed
Dec 26, 2021
`cabal v2-build all --enable-tests --enable-benchmarks` inferres 1 version per dep keeping all targets. People (frequently) & CI do `test` & `bench` separately. So `all tests` & `all bench` deps may not end up. Even current code does not match the CI guarantees, as all plugins get `test` separately, so their deps can not match-up. `caching` should not assume guarantees bigger then provided.
This workaround was not addressing the CI behaviour.
Anton-Latukha
force-pushed
the
2021-12-24-upd-caching
branch
from
c9666eb
to
27ec2c8
Compare
Anton-Latukha
changed the title
all && test && benchmark dep inconsistencies
|
I reformulated the PR to address the most important stuff in it. To match the process completely - we would need to run the |
Efficient use of available space.
|
[skip circleci] |
jneira
reviewed
Dec 27, 2021
jneira
reviewed
Dec 27, 2021
jneira
reviewed
Dec 27, 2021
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
|
Nice review. Would belabor additionally: now CI would start to cache |
|
After the recent merge |
drsooch
pushed a commit
to drsooch/haskell-language-server
that referenced
this pull request
Dec 29, 2021
* CI: caching: do `bench` & `test` separately
`cabal v2-build all --enable-tests --enable-benchmarks` inferres 1 version per dep
keeping all targets.
People (frequently) & CI do `test` & `bench` separately.
So `all tests` & `all bench` deps may not end up.
Even current code does not match the CI guarantees, as all plugins get `test`
separately, so their deps can not match-up.
`caching` should not assume guarantees bigger then provided.
* CI: caching: rm workaround
This workaround was not addressing the CI behaviour.
* CI: {caching, test, bench}: output `freeze` or warning
* CI: {caching, test, bench}: m v2-update unification
* CI: caching: do bench caching only for what gets used
Efficient use of available space.
* CI: caching: fx benchmark caching step
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
* CI: {caching, test, bench}: `haskell/actions/setup` does the update
* CI: caching: m fx
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cabal v2-build all --enable-tests --enable-benchmarkproblem - that command requires the level of dependency consistency guarantees that PR CI does not checks.testworkflow does essentiallycabal v2-build --enable-testson matrix by target.benchworkflow doescabal v2-build --enable-benchmarksby target.cachingusedall --enable-tests --enable-benchmarks- requiring total consistency.These changes are to make
cachingable to work whentest&benchdepsversions are inconsistent (which is how CI & people use them - separately).
Workaround to CI platform" needs to be removed either way, since I found out post hooks does not run if any of (even markedcontinue-on-error: true) steps fail.