Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wingman: Fix #1879 #2644

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Wingman: Fix #1879 #2644

merged 2 commits into from
Jan 28, 2022

Conversation

MorrowM
Copy link
Contributor

@MorrowM MorrowM commented Jan 27, 2022

Adds a special case in order to fix #1879

@jneira jneira requested a review from isovector January 27, 2022 15:21
@isovector
Copy link
Collaborator

Thanks for tackling this! Mind adding a quick test?

It's quick: add a new file with a hole, like this one:

https://github.com/haskell/haskell-language-server/blob/0905e682de8cc3e2bfe509313924cff0527b6791/plugins/hls-tactics-plugin/test/golden/GoldenArbitrary.hs

and then add the line, column and filename of the hole to this file:

running the tests will then generate the expected test output, and is good to check in.

Thanks so much!

Copy link
Collaborator

@isovector isovector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much!

@isovector isovector added the merge me Label to trigger pull request merge label Jan 28, 2022
@mergify mergify bot merged commit c1bea2d into haskell:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wingman produces silly arbitrary instance for single-constructor types
2 participants