Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hie-bios 0.9.0 #2738

Merged
merged 6 commits into from
Feb 27, 2022

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Feb 25, 2022

New hie-bios release!

Big thanks to @hasufell, @Kleidukos, @jneira and more who made this release possible.

Big Change: haskell/hie-bios#282

TLDR; hie-bios (consequentially HLS) will now honour the with-compiler field in cabal.project!

@fendor fendor marked this pull request as draft February 25, 2022 13:19
@fendor fendor force-pushed the feature/upgrade-hie-bios-0.9.0 branch from edd47fa to dffa08b Compare February 25, 2022 13:26
@fendor fendor changed the title Try out new hie-bios Upgrade to hie-bios 0.9.0 Feb 25, 2022
@fendor fendor marked this pull request as ready for review February 25, 2022 21:51
ghcide/ghcide.cabal Outdated Show resolved Hide resolved
Co-authored-by: Julian Ospald <hasufell@posteo.de>
@berberman
Copy link
Collaborator

I think we should update this line

# GHCIDE requires hie-bios >=0.8 && <0.9.0
hie-bios = hself.hie-bios_0_8_0;

to

hie-bios = hself.callCabal2nix "hie-bios" inputs.hie-bios {};

flake.nix Outdated Show resolved Hide resolved
Co-authored-by: Potato Hatsue <berberman@yandex.com>
@michaelpj michaelpj added the merge me Label to trigger pull request merge label Feb 27, 2022
@hasufell hasufell mentioned this pull request Feb 27, 2022
25 tasks
@mergify mergify bot merged commit 0c018ac into haskell:master Feb 27, 2022
michaelpj added a commit to michaelpj/haskell-language-server that referenced this pull request Mar 1, 2022
haskell#2738 updated
`flake.nix` but not `flake.lock`.

`nix develop` will just modify `flake.lock` locally, but `nix-shell`
will actually fail without this.
@michaelpj michaelpj mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants