Fix broken call-hierarchy-plugin-tests for type signatures #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
July541
force-pushed
the
call-hierarchy-tests-9.4
branch
from
b79ff61
to
3cc39a3
Compare
July541
commented
Sep 18, 2022
| _ -> Nothing | ||
| renderTyDecl = case ident of | ||
| Left _ -> Nothing | ||
| Right name -> case getNameBinding name (getAsts hf) of |
There was a problem hiding this comment.
Here is the core. From getNameBindingInClass to getNameBinding.
pepeiborra
approved these changes
Sep 18, 2022
plugins/hls-call-hierarchy-plugin/src/Ide/Plugin/CallHierarchy/Types.hs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some refactoring by the way.