Sort vscode extension schema json by keys #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
commented
Sep 20, 2022
| | PrintExtensionSchema | ||
| | PrintDefaultConfig |
There was a problem hiding this comment.
For anyone who was wondering, this was the actual codepath taken, instead of VSCodeExtensionSchemaMode from src/Ide/Main.hs. That used to be dead-code.
Makes it easier to copy and paste configurations into VSCode and reviewing what options have been added and removed. Remove code-duplication, namely ghcide exe loses some capabilities, as it is destined to be removed sooner or later.
fendor
force-pushed
the
fix/sort-actions
branch
from
8a6932c
to
d92a59a
Compare
|
Actually, isn't there supposed to be a |
michaelpj
approved these changes
Sep 21, 2022
|
I assume the sorting means that we do get options for the same plugin near each other because they will have the same prefix? |
|
yes, that's the idea, lexicographic sorting should take care of it. Unless my brain is messing up again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to copy and paste configurations into VSCode and reviewing what options have been added and removed. I was reminded that we need something like this and add this to the release checklist for HLS, since we forgot to add Stan options vscode.
Remove code-duplication, namely ghcide exe loses some capabilities, as it is destined to be removed sooner or later.