Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable plugin tests in CI for GHC 9.4 #3420

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Enable plugin tests in CI for GHC 9.4 #3420

merged 3 commits into from
Dec 22, 2022

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Dec 21, 2022

We neglected to enable testing in CI of all the newly patched plugins for GHC 9.4

@wz1000 wz1000 force-pushed the wip/fix-9.4-tests branch 3 times, most recently from 08a16e5 to bacbd40 Compare December 21, 2022 21:45
pepeiborra
pepeiborra approved these changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this!

@wz1000 wz1000 force-pushed the wip/fix-9.4-tests branch 2 times, most recently from b792d64 to f6019b3 Compare December 21, 2022 22:58
@michaelpj
Copy link
Collaborator

Oof, good catch!

@mpickering
Copy link
Contributor

Good work Zubin.

konn
konn approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@konn konn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! 👍

@wz1000 wz1000 added the merge me Label to trigger pull request merge label Dec 22, 2022
fendor
fendor approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/hls-refactor-plugin/test/Main.hs Outdated Show resolved Hide resolved
plugins/hls-refactor-plugin/test/Main.hs Outdated Show resolved Hide resolved
@mergify mergify bot merged commit e7b1ef0 into master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konn konn konn approved these changes

@pepeiborra pepeiborra pepeiborra approved these changes

@fendor fendor fendor approved these changes

@Anton-Latukha Anton-Latukha Awaiting requested review from Anton-Latukha

@Ailrun Ailrun Awaiting requested review from Ailrun

@ozkutuk ozkutuk Awaiting requested review from ozkutuk

@uhbif19 uhbif19 Awaiting requested review from uhbif19

@isovector isovector Awaiting requested review from isovector

@kokobd kokobd Awaiting requested review from kokobd

@santiweight santiweight Awaiting requested review from santiweight santiweight is a code owner

@OliverMadine OliverMadine Awaiting requested review from OliverMadine

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo is a code owner

@berberman berberman Awaiting requested review from berberman

@georgefst georgefst Awaiting requested review from georgefst

@July541 July541 Awaiting requested review from July541

@VeryMilkyJoe VeryMilkyJoe Awaiting requested review from VeryMilkyJoe

@drsooch drsooch Awaiting requested review from drsooch

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wz1000 @michaelpj @mpickering @konn @pepeiborra @fendor