update flakes to compile with ghc928 and ghc962 #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smunix
commented
Jun 10, 2023
| @@ -60,8 +60,18 @@ | |||
| flake = false; | |||
| }; | |||
|
|
|||
| fourmolu-012 = { | |||
| url = "https://hackage.haskell.org/package/fourmolu-0.12.0.0/fourmolu-0.12.0.0.tar.gz"; | |||
| # smunix: github:haskell/hie-bios defines | |||
There was a problem hiding this comment.
Here's a more detailed explanation of the reasons why I had to patch implicit-hie-cradle
There was a problem hiding this comment.
PRs welcome on implicit-hie* repos. Saddly I don't have much time for Haskell these days. If your 0.5 branch is ready make a PR and I'll publish that to hackage tomorrow.
There was a problem hiding this comment.
Will give it another week; we may need to coordinate with a separate PR for a new version of HLS. That effort is still ongoing
smunix
force-pushed
the
smunix-patch-6
branch
2 times, most recently
from
dfc1595
to
d287267
Compare
(there doesn't appear to be any functional changes)
|
@smunix this is ready to go? I am not really reviewing this, but CI is green, so I assume this is good |
fendor
approved these changes
Jun 12, 2023
Yes, this is ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mpickering @guibou @Avi-D-coder @pepeiborra @michaelpj -
To ensure successful compilation of HLS with the recent nix update, I had to apply a patch to the 'implicit-hie-cradle' package. However, I've noticed that there are multiple repositories containing 'hie-bios' related packages that HLS relies on, each at different versions. These repositories include:
Adding another repository (github:smunix/implicit-hie-cradle@smunxi-patch-hls-1) to address the compilation issue might be exacerbating the situation. Hence, I'm submitting this pull request to initiate a discussion regarding a unified strategy going forward. I would appreciate your thoughts on this matter.
edit: You can find the minimalistic changes I made at the following link: GitHub - smunix/implicit-hie-cradle