Adapt to lsp changes for workspace/configuration #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
force-pushed
the
mpj/configuration
branch
from
667a3c8
to
502b312
Compare
|
Stack builds will fail since I haven't put the git dep in there. Shouldn't be a problem once we're using a released |
|
It looks like you are just going to satisfy the lsp changes, LGTM. |
michaelpj
requested review from
joyfulmantis,
ozkutuk,
Ailrun,
konn,
kokobd,
pepeiborra,
santiweight,
OliverMadine,
eddiemundo,
berberman,
georgefst,
July541,
VeryMilkyJoe,
fendor and
drsooch
as code owners
michaelpj
force-pushed
the
mpj/configuration
branch
from
a2613c6
to
236e790
Compare
This has a few substantive changes and a lot of messing with tests. - We now tell `lsp` our config section, and parse just that section. - We move the logic for updating the shake build rules for client config from a `workspace/didChangeConfiguration` handler to the new `lsp` callback, which will ensure it gets called in all circumstances that can be relevant. The test changes are more annoying: - We ignore config and logging messages by default now, so we have to stop doing that when we care about it. - Many tests didn't really need to _change_ the config, but rather just to set it once at the beginning. I adjusted a lot of test functions to allow passing in the initial config for this reason.
michaelpj
force-pushed
the
mpj/configuration
branch
from
41d8222
to
50796ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: depends on unreleased
lspcode, I expect I still messed some stuff up with the testsThis has a few substantive changes and a lot of messing with tests.
lspour config section, and parse just that section.workspace/didChangeConfigurationhandler to the newlspcallback, which will ensure it gets called in all circumstances that can be relevant.The test changes are more annoying: