Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to lsp changes for workspace/configuration #3773

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Commits on Aug 25, 2023

  1. Adapt to lsp changes for workspace/configuration

    This has a few substantive changes and a lot of messing with tests.
    
    - We now tell `lsp` our config section, and parse just that section.
    - We move the logic for updating the shake build rules for client config
      from a `workspace/didChangeConfiguration` handler to the new `lsp`
      callback, which will ensure it gets called in all circumstances that
      can be relevant.
    
    The test changes are more annoying:
    - We ignore config and logging messages by default now, so we have to
      stop doing that when we care about it.
    - Many tests didn't really need to _change_ the config, but rather just
      to set it once at the beginning. I adjusted a lot of test functions to
      allow passing in the initial config for this reason.
    michaelpj committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7a6e6f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd421cc View commit details
    Browse the repository at this point in the history
  3. Fix stan plugin

    michaelpj committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    50796ed View commit details
    Browse the repository at this point in the history
  4. Doh

    michaelpj committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    0b3caa4 View commit details
    Browse the repository at this point in the history