Don't run hlint on testdata directories

[fendor]

closes #3900

[fendor]

@soulomoon Does this look good?

[soulomoon]

weird, it is still there, take a look at https://github.com/haskell/haskell-language-server/actions/runs/7206841824/job/19632462805?pr=3901#step:4:133.

[soulomoon]

perhaps it is some kind of HLint bug?

[fendor]

Hm, maybe it only accepts the ignore-glob param once?

[fendor]

No, no idea, can't reproduce locally with version 3.6.1.

[soulomoon]

May be we can try to bumbup the version to 3.6.1 ?

[michaelpj]

Can we not put this in the .hlint.yaml file or something so it's always applied?

[fendor]

No, ignore-glob is seemingly only recognised by the cli. But on CI, not even that seems to be true.

[fendor]

I did it! It looks like @actions/exec does something funky with cmd arguments that contain quotes. I don't really know what's going, but I am suspecting that a shell is acting up, maybe escaping or resolving *?

[soulomoon]

LGTM, it seems checks for the testdata's files are gone.

[michaelpj]

What's this file doing, then? Isn't it exactly what we want? https://github.com/haskell/haskell-language-server/blob/master/plugins/hls-semantic-tokens-plugin/.hlint.yaml

[fendor]

Yeah that looks good, I was looking for a different option, apparently. Will update the PR and delete the respective .hlint.yaml files.

[fendor]

Doesn't seem to be working yet

[soulomoon]

Since none of us can repro locally, I tend to think there is a Github action CI up stream bug.

[fendor]

Adding

- ignore: { "within": '**/testdata/**' }
- ignore: { "within": '**/test/data/**' }

does not work for me locally either. That may be a hlint bug worth discussing upstream.

[soulomoon]

locally testing, ditto
create a ticket to hlint ndmitchell/hlint#1552

[soulomoon]

I realize, It might be a confliction between --git and --ignore-glob @fendor

[soulomoon]

I found the source, this pull request ndmitchell/hlint#1552 should fix the ignore-glob problem.

[soulomoon]

looking good, the problem should be fixed with it once the hlint support ignore glob with arg --git

[michaelpj]

This seems semantically correct even if there's a hlint problem, so let's merge it anyway.