Don't produce diagnostics if plugin is turned off #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
reviewed
Jan 11, 2024
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/Completion/Types.hs
Outdated
Show resolved
Hide resolved
fendor
force-pushed
the
enhance/cabal-no-diags-if-disabled
branch
from
faa1c60
to
e9aab3c
Compare
soulomoon
added a commit
to soulomoon/haskell-language-server
that referenced
this pull request
Jan 12, 2024
commit 2fe2d70 Merge: 034b33e bea1fed Author: fendor <fendor@users.noreply.github.com> Date: Thu Jan 11 16:05:34 2024 +0100 Merge pull request haskell#3941 from fendor/enhance/cabal-no-diags-if-disabled Don't produce diagnostics if plugin is turned off commit bea1fed Merge: e9aab3c 034b33e Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Date: Thu Jan 11 13:54:12 2024 +0000 Merge branch 'master' into enhance/cabal-no-diags-if-disabled commit e9aab3c Author: Fendor <power.walross@gmail.com> Date: Wed Jan 10 17:18:39 2024 +0100 Don't produce diagnostics if plugin is turned off commit 034b33e Author: 0rphee <0rph3e@proton.me> Date: Thu Jan 11 02:53:11 2024 -0600 Use stan config files for stan plugin (haskell#3904) (haskell#3914) * Bump stan Needed in order to get the functions for getting the config, etc. * Use stan config files for stan plugin (haskell#3904) * Add test case for .stan.toml configuration * Fix windows tests See kowainik/stan#531 --------- Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant for #3939
(I didn't test this change, but it is identical to https://github.com/haskell/haskell-language-server/blob/master/plugins/hls-stan-plugin/src/Ide/Plugin/Stan.hs#L82)