Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix most hlint warnings in ghcide #3975

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Fix most hlint warnings in ghcide #3975

merged 3 commits into from
Jan 18, 2024

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Jan 17, 2024 •
edited
Loading

If nothing else, I hope this will reduce the amount of hlint warnings that are showing up in unrelated PRs.

michaelpj
michaelpj approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'd consider all of these strict improvements, but nice to quieten things down. I think we should also just be aggressive about turning off stuff we don't like in hlint.yaml

@jhrcek
Copy link
Collaborator Author

jhrcek commented Jan 18, 2024

CI passed, ready for merge.

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jan 18, 2024
@mergify mergify bot merged commit 78f510e into haskell:master Jan 18, 2024
42 checks passed
@jhrcek jhrcek deleted the jhrcek/ghcide-hlint branch January 19, 2024 04:14
josephsumabat pushed a commit to josephsumabat/haskell-language-server that referenced this pull request Jan 22, 2024
@jhrcek @mergify @josephsumabat
Fix most hlint warnings in ghcide (haskell#3975)
1773262 
* Fix most hlint warnings in ghcide

* stylish-haskell

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@fendor fendor Awaiting requested review from fendor fendor is a code owner

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhrcek @michaelpj