Fix references to old CPP names in tests, update tests #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft as the fixed eval plugin test is quite unstable and slow. Will check it out in detail tomorrow. |
jhrcek
commented
Apr 6, 2024
| @@ -37,7 +37,7 @@ tests = | |||
|
|
|||
| (codeLensResponse, activeProgressTokens) <- expectProgressMessagesTill | |||
| (responseForId SMethod_TextDocumentCodeLens lspId) | |||
| ["Setting up testdata (for T1.hs)", "Processing", "Indexing"] | |||
| ["Setting up testdata (for T1.hs)", "Processing"] | |||
There was a problem hiding this comment.
Removing this Indexing because it was making the test flaky (sometimes appeared after the code lens reponse).
As suggested by @fendor the only Indexing message that happens is related to files not related to this test, so it also semantically doesn't belong here.
fendor
approved these changes
Apr 6, 2024
fendor
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up where #4129 left off + includes test fixes.
One of the fixed tests seems to be flaky so might require some stabilization..