Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should haskell-cabal mode derive from prog-mode? #1819

Closed
cumber opened this issue Aug 14, 2023 · 4 comments
Closed

Should haskell-cabal mode derive from prog-mode? #1819

cumber opened this issue Aug 14, 2023 · 4 comments

Comments

@cumber
Copy link

cumber commented Aug 14, 2023

Back in #86 haskell-mode was updated to derive from prog-mode rather than fundamental-mode. Should haskell-cabal mode follow suit?

At the moment basic configuration I want to apply to all programming modes (or even all programming and text modes, but not things like menus) has to additionally single out haskell-cabal mode.

@purcell
Copy link
Member

purcell commented Aug 14, 2023

Should haskell-cabal mode follow suit?

Not really, sorry. If you look at other configuration and markup modes (conf-toml-mode, yaml-mode, xml-mode), you won't find prog-mode among the parent modes.

@purcell purcell closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
@purcell
Copy link
Member

purcell commented Aug 14, 2023

However, I noticed haskell-cabal-mode also wasn't derived from text-mode, which would be typical, so I've just changed the mode so that it is. That should ease your configuration a bit.

@cumber
Copy link
Author

cumber commented Aug 14, 2023

Yeah, I wasn't sure which would be most appropriate. I ended up suggesting prog-mode since "Text mode is a major mode for editing human languages" according to https://www.gnu.org/software/emacs/manual/html_node/elisp/Basic-Major-Modes.html. I suppose markup languages are often used to mark-up content that is human-language text, but cabal file content really doesn't feel like "text" to me.

But I'm fine with a ruling that text-mode is more appropriate here. Thanks!

@purcell
Copy link
Member

purcell commented Aug 14, 2023

Agree, yaml also doesn't feel like text to me. Or XML for that matter! But they are both derived from text-mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants