Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with htmlize 1.47 #596

Closed
pyr opened this issue Apr 23, 2015 · 2 comments
Closed

Incompatibility with htmlize 1.47 #596

pyr opened this issue Apr 23, 2015 · 2 comments

Comments

@pyr
Copy link
Contributor

pyr commented Apr 23, 2015

Hi there!

htmlize (at version 1.47) recently stopped working with haskell. This is because of extra quoting when defining faces I had to change the lines:

(defface haskell-keyword-face
  '((t :inherit 'font-lock-keyword-face))
  "Face used to highlight Haskell keywords."
  :group 'haskell)

And remove the extraneous quoting:

(defface haskell-keyword-face
  '((t :inherit font-lock-keyword-face))
  "Face used to highlight Haskell keywords."
  :group 'haskell)

The same goes for every face declaration (https://github.com/haskell/haskell-mode/blob/master/haskell-font-lock.el#L91-L131). If this change does not introduce problems with earlier emacs/htmlize builds, I can provide a PR to fix this.

@gracjan
Copy link
Contributor

gracjan commented Apr 23, 2015

For those oblivious what htmlize is: http://fly.srk.fer.hr/~hniksic/emacs/htmlize.el.cgi

@pyr: Note that font-lock documentation states:

Note that in new code, in the vast majority of cases there is no need to
create variables that specify face names. Simply using faces directly
is enough. Font-lock is not a template to be followed in this area.

That is why it got changed.

@pyr, please provide PR, we will check and see what to do with this.

@gracjan gracjan changed the title incompatibility with htmlize 1.47 Incompatibility with htmlize 1.47 Apr 23, 2015
@pyr
Copy link
Contributor Author

pyr commented Apr 23, 2015

Hi @gracjan thanks for the comments. I attached a PR with the fix that resolve the situation for now.
Using standard face names seems like a really good idea for the future indeed.

gracjan added a commit that referenced this issue Apr 23, 2015
remove extra quoting. fixes #596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants