Add an alias to fix the breakage of #1375 #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would prefer a version that wraps up the call to |
You're right, I forgot about that. I'll update the PR. |
In haskell#1375, `haskell-guess-module-name` was renamed to `haskell-guess-module-name-from-file-name` which caused breakage for users of the original function name. Fix the breakage by defining a stub function `haskell-guess-module-name` which calls `haskell-guess-module-name-from-file-name` with the buffer's file name.
|
Thanks. |
|
This has different semantics if the module name can't be guessed: previously it would return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1375,
haskell-guess-module-namewas renamed tohaskell-guess-module-name-from-file-namewhich caused breakage forusers of the original function name. Fix the breakage by defining an
alias that makes the original name point to the new function name.