Display "Collecting type info for N module(s) ..." message for GHC 8 #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracjan
reviewed
Oct 26, 2016
| @@ -88,7 +88,14 @@ Restarts the SESSION's process if that is the case." | |||
| ((haskell-process-consume process "\nBuilding \\(.+?\\)\\.\\.\\.") | |||
| (let ((msg (format "Building: %s" (match-string 1 buffer)))) | |||
| (haskell-interactive-mode-echo (haskell-process-session process) msg) | |||
| (haskell-mode-message-line msg))))) | |||
| (haskell-mode-message-line msg))) | |||
| ((string-match "\\(Collecting type info for [[:digit:]]+ module(s) ...\\)" | |||
There was a problem hiding this comment.
Please remove the \\( and \\) and use string-match 0 instead of string-match 1 later on.
|
Overall it is a shame that we do not have any automated tests for this kind of stuff. Next time a GHC 8.0.x or 9.x comes out it may change this string and functionality will silently fail. |
|
This is second time we've beaten by changed GHC output. You're right, we should have tests for all GHC output parsing code pieces. |
|
I've made changes you've proposed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.