Reduce (over)use of markers (#1751) #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser used by the font-lock code created a massive amount of markers; try to reduce it as far as possible since they make some operations expensive as long as they are in the buffer. Even orphaned markers stay until next GC. Read match data as integers instead of markers, and don't create new markers when setting the match data. This should work just fine as long as the buffer isn't changed during the match data lifetime, which appears reasonable.
sergv
added a commit
to sergv/dotemacs
that referenced
this pull request
Jan 21, 2023
This is a port of haskell/haskell-mode#1760 pull request. Original commit message: The parser used by the font-lock code created a massive amount of markers; try to reduce it as far as possible since they make some operations expensive as long as they are in the buffer. Even orphaned markers stay until next GC. Read match data as integers instead of markers, and don't create new markers when setting the match data. This should work just fine as long as the buffer isn't changed during the match data lifetime, which appears reasonable.
sergv
added a commit
to sergv/dotemacs
that referenced
this pull request
Feb 20, 2023
This is a port of haskell/haskell-mode#1760 pull request. Original commit message: The parser used by the font-lock code created a massive amount of markers; try to reduce it as far as possible since they make some operations expensive as long as they are in the buffer. Even orphaned markers stay until next GC. Read match data as integers instead of markers, and don't create new markers when setting the match data. This should work just fine as long as the buffer isn't changed during the match data lifetime, which appears reasonable.
|
Makes sense to me so will merge. I'm taking a short time to catch up on some PRs like this which have been languishing, thanks for your patience. |
|
You are very diligent indeed, thank you! |
sergv
added a commit
to sergv/dotemacs
that referenced
this pull request
Oct 24, 2023
This is a port of haskell/haskell-mode#1760 pull request. Original commit message: The parser used by the font-lock code created a massive amount of markers; try to reduce it as far as possible since they make some operations expensive as long as they are in the buffer. Even orphaned markers stay until next GC. Read match data as integers instead of markers, and don't create new markers when setting the match data. This should work just fine as long as the buffer isn't changed during the match data lifetime, which appears reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser used by the font-lock code created a massive amount of
markers; try to reduce it as far as possible since they make some
operations expensive as long as they are in the buffer. Even orphaned
markers stay until next GC.
Read match data as integers instead of markers, and don't create new
markers when setting the match data. This should work just fine as
long as the buffer isn't changed during the match data lifetime, which
appears reasonable.