Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoogle: colorize hoogle cli output using haskell-mode font-lock #1786

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

jaor
Copy link
Contributor

@jaor jaor commented Sep 17, 2022

It's been a long time since hoogle command line interface lost the ability to
output ANSI colors (see ndmitchell/hoogle#133).

This patch makes haskell-hoogle to use emacs font lock to fontify its output,
with a custom flag to opt out.

It's been a long time since hoogle command line interface lost the ability to
output ANSI colors (see ndmitchell/hoogle#133).

This patch makes haskell-hoogle to use emacs font lock to fontify its output,
with a custom flag to opt out.
@purcell
Copy link
Member

purcell commented Mar 3, 2023

This makes sense to me, but if it actually works then I'd suggest we do without the flag. Or does it not work so well? My rationale here is: the fewer knobs and switches, the better.

@jaor
Copy link
Contributor Author

jaor commented Mar 4, 2023 via email

@purcell purcell merged commit 20d4e23 into haskell:master Mar 4, 2023
@purcell
Copy link
Member

purcell commented Mar 4, 2023

Okay, I removed the defcustom and merged the changes — thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants