Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape single quote in docstring #1792

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

syohex
Copy link
Contributor

@syohex syohex commented Nov 6, 2022

Development Emacs(version 29) warns not escaped quotes in docstring as below. This PR fixes this issue and makes make command success on development Emacs too.

In haskell-cabal-classify-line:
haskell-cabal.el:363:2: Warning: docstring has wrong usage of unescaped single
    quotes (use \= or different quoting)

@@ -150,6 +150,7 @@ $(AUTOLOADS): $(ELFILES)
$(BATCH) \
--eval '(setq make-backup-files nil)' \
--eval "(setq generated-autoload-file (concat command-line-default-directory \"/\" \"$@\"))" \
--eval "(require 'autoload)" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoload.el will be obsoleted since Emacs 29. So it is necessary to load explicitly on latest Emacs.

@@ -362,8 +362,8 @@ OTHER-WINDOW use `find-file-other-window'."

(defun haskell-cabal-classify-line ()
"Classify the current line's type.
Possible results are 'section-header 'subsection-header 'section-data 'comment
and 'empty '"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove needless quote

@purcell purcell merged commit 53d2626 into haskell:master Nov 6, 2022
@purcell
Copy link
Member

purcell commented Nov 6, 2022

Thank you!

@syohex syohex deleted the escape-quote-in-docstring branch November 6, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants