add optional single-line-p in haskell-process-show-repl-response #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `SINGLE-LINE-P` as nil, it echos the response as is. This allows the response to remain multi lined, which is better for error reponses.
|
This isn't an interactive command, so it's not clear to me who would actually call this function with that new additional parameter. What am I missing? |
|
Well actually, this is for my personal use. I was working on my inferior haskell mode and found that modification to this function would be deseriable. But it may not be beneficial to other users, plus I had not been working with haskell since, so I will close it. |
|
Great, thanks for confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
SINGLE-LINE-Pas nil, it echos the response as is. This allows the response to remain multi lined, which is better for error reponses.