Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permanent haskell-doc mode. #1799

Closed
wants to merge 1 commit into from
Closed

Conversation

ErnestKz
Copy link

The eldoc-documentation-function is turned on regardless if haskell-doc-mode is on or off, and it is hard to find a way to disable it.

haskell-doc-mode still works as intended, and actually turns off the eldoc popup when the mode is disabled.

@purcell
Copy link
Member

purcell commented Feb 28, 2023

Thanks @ErnestKz! haskell-doc-mode was a bit overengineered so I've put together an alternative approach in #1802 — would you mind taking a look?

@purcell
Copy link
Member

purcell commented Mar 3, 2023

Replaced by #1802

@purcell purcell closed this Mar 3, 2023
@ErnestKz
Copy link
Author

ErnestKz commented Mar 4, 2023

Thank you for the tidy up. I just pulled down the commit and tried it out, and it works!

@purcell
Copy link
Member

purcell commented Mar 6, 2023

Super, thanks for the feedback, and prompting these changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants