Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes made while trying to get debian package working with emacs 29.1 #1815

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

barak
Copy link
Contributor

@barak barak commented Aug 3, 2023

These are some minor fixes, like stray version numbers and some spelling errors and such. Plus one more serious change, to make it easier to debug lexical test cases by actually returning a list of tokens. This also avoids some ugly code duplication.

Upstream forgot to update some stray "17.2-git" version strings to "17.3".

Gbp-Pq: Name 0003-version-update.patch
Modify haskell-lexeme-tests so check-lexemes-nocheck returns a list of
tokens instead of just failing if the tokenization fails, and then use
it to simplify check-lexemes.

"Premature optimization is the root of all evil."
@purcell
Copy link
Member

purcell commented Aug 4, 2023

The previous versions were like this to indicate that the master version of the code was approaching 17.2, so the new equivalent would be 17.4-git.

But after consideration, I'll just merge this as-is, as it relates to #1755. Thanks!

@purcell purcell merged commit e835894 into haskell:master Aug 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants