Use haskell-process-compute-process-log-and-command in haskell-process-start #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the point of this so when I get time to merge it I'll know why? Cheers |
|
During refactoring somebody removed the process-log-and-compute function call which resulted in haskell-process-wrapper-function no longer being used. This commit uses the still existing process-log-and-compute function again so that haskell-process-wrapper-function is actually used. |
|
Oh, |
cocreature
changed the title
|
Anything wrong with it or did you just not have time to look at it? |
|
Looks okay. Tested it, didn't break anything. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you oppose to the indentation changes, I'll take those out. I just thought those lines were way too long. Also I'm a really bad lisper, so I hope I didn't break anything.