Wrap session target #518
Merged
Wrap session target #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locally you can run tests by: |
cocreature
force-pushed
the
wrap-session-target
branch
from
4f6e301
to
b2afa01
Compare
|
Ah sorry, didn't see that there are tests. I changed the test as this is exactly what this pull request is trying to accomplish. |
|
Merged. @cocreature, do you see other issues that could use some improvement? |
|
Nope, when I'll find issues I'll report and/or try to fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session target needs to be wrapped too otherwise it gets passed as an argument to the wrapping command.