New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite: Do checks on UnicodeSyntax, too. #716
Conversation
Right, good catch. This would affect
Fair enough. I don’t know anything about ERT, but I wonder if one could do this automatically and still have nominally separate units for Unicode and ASCII (generating units on the fly before a test run?). A mixture case could be added manually. If the parsing haskell-indentation does is uniform, one could just have a single test case for indentation with UnicodeSyntax; but looking over the file, there appeared to be a lot of individual literal references to things like |
For now please just copy&paste the tests that are interesting and change
Unicode where you need.
We can generalize later when we know how to do it.
Please mark those tests that fail as:
:expected_result :failed
|
564de05
to
93618fa
Compare
Ah, you added a new one. Rebased! |
Just for the ones that should fail, though, right? Or does this have something to do with CI? |
Yes, make TravisCI happy. The actual fixes will come later.
|
93618fa
to
7290d44
Compare
Test suite: Do checks on UnicodeSyntax, too.
Great! Thanks! Now we need to actually fix it :) |
:) |
This automatically transforms check input to UnicodeSyntax and
runs the test twice; once on the original, once on the Unicode
version.
Note that I don’t really know what I’m doing with my Elisp. Is this
usable to you? In my test it catches #715.
Since this is using a dumb search&replace, instead of requiring
separate tests for Unicode cases, e. g. things like
->
can’t be usedin Haskell strings inside of the test cases, which is probably not an
issue.