Add support for non-standard cabal.project file locations to cabal cradles #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Aug 18, 2022
| projectLocationOrDefault :: CradleProjectConfig -> [FilePath] | ||
| projectLocationOrDefault = \case | ||
| NoExplicitConfig -> ["cabal.project", "cabal.project.local"] | ||
| (ExplicitConfig prjFile) -> [prjFile, prjFile <.> "local"] |
There was a problem hiding this comment.
Should the explicit config include the .local file? Or will cabal pick it up automatically if it has the main project file?
There was a problem hiding this comment.
This is used for cabal cradle dependencies, e.g. telling HLS that the cradle needs to be reloaded if either of the two changes. IIRC, that behaviour is in line with cabal.
However, the name is misleading.
fendor
changed the title
6 tasks
|
@fendor what's the status on this PR? Do you think you can spare some time to solve the conflicts / rebase it? |
|
@Kleidukos Sure, do you have a use-case for this feature? |
|
@fendor I personally don't, but a post on the Discourse could certainly gauge the interest for this feature :) |
fendor
force-pushed
the
feature/cabal-project
branch
2 times, most recently
from
023067d
to
1f8d512
Compare
Add parser tests for cabal.project files Add bios tests for cabal.project files
fendor
force-pushed
the
feature/cabal-project
branch
from
1f8d512
to
91c7348
Compare
michaelpj
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parser tests for non-standard
cabal.projectfile locationsAdd bios tests for projects with non-standard
cabal.projectfile locationsFollows the same structure as
stackYamlfeature for stack cradles.Fixes #263