Re-remove re-exports, minimal bounds, CI #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozross
changed the title
emilypi
approved these changes
May 1, 2022
There was a problem hiding this comment.
herculean 💪
Re:
I've asked about whether we dealt with other re-exports or not: I assume you only meant those three in your item, but I had to check. This is a necessary preliminary to other work.
Deferring to @chessai, but I believe those three were the offending re-exports.
phadej
reviewed
May 3, 2022
| -- This is a SafeHaskell safeguard (pun intended) to explicitly declare the API contract of `mtl` | ||
| -- GHC versions before 7.4 were hopelessly broken or incapable of SafeHaskell | ||
| if impl(ghc >= 7.4) | ||
| default-extensions: Safe |
There was a problem hiding this comment.
Removal of default-extensions: Safe may allow some modules to became unsafe unnoticed. Please add it back.
This was referenced May 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes multiple required milestones in #86:
Control.Monad,Control.Monad.FixandData.Monoidare gone.cabal-install3.0.transformers-0.5.6.@emilypi I've asked about whether we dealt with other re-exports or not: I assume you only meant those three in your item, but I had to check. This is a necessary preliminary to other work.