Work around historical behavioural oddity with UNIX domain sockets #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed UNIX domain sockets inspired by https://stackoverflow.com/a/13719866
kazu-yamamoto
requested changes
May 24, 2020
Network/Socket/SockAddr.hs
Outdated
| res <- try (G.bind s a) | ||
| case res of | ||
| Right () -> pure () | ||
| Left e -> if not (isAlreadyInUseError (e :: IOException)) |
There was a problem hiding this comment.
Why don't you use | isAlreadyInUseError (e :: IOException) instead of if.
There was a problem hiding this comment.
Done in 8d5ff8d - though I've kept the error conditions grouped together at the top as I think that's visually easier to read, hope that's OK.
There was a problem hiding this comment.
Please don't forget pure in tests.
There was a problem hiding this comment.
woops, also done now in f27b87c
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
May 25, 2020
|
Rebased and merged. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally part of #428. Hopefully the code & commit messages should be self-explanatory. TD;LR version is that bind doesn't clean up after itself, this works around that.