Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bytestring 0.11 #490

Closed
wants to merge 1 commit into from
Closed

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Nov 16, 2020

@sjakobi
Copy link
Member Author

sjakobi commented Nov 16, 2020

So far I've only tested this by running the testsuite locally on a Linux machine.

@kazu-yamamoto
Copy link
Collaborator

I took much time to try using bytestring 0.11 but I cannot use it yet. So, I cannot test this PR at this moment, sigh.

@sjakobi
Copy link
Member Author

sjakobi commented Nov 17, 2020

I took much time to try using bytestring 0.11 but I cannot use it yet. So, I cannot test this PR at this moment, sigh.

Is your package list up-to-date? unix was made compatible only a few hours ago: haskell/unix#162 (comment)

After cabal update, I could successfully run cabal test --constraint 'bytestring >= 0.11'.

@Bodigrim
Copy link

Bodigrim commented Dec 2, 2020

@kazu-yamamoto cabal test --constraint bytestring==0.11.0.0 works just fine for me. Or alternatively one can test with stack:

resolver: lts-12.24
packages:
- '.'
nix:
  packages: [ ncurses ]

# XXX workaround
# https://github.com/commercialhaskell/stack/issues/2245
hide-th-loading: false

extra-deps:
- bytestring-0.11.0.0
- directory-1.3.6.1
- unix-2.7.2.2
- hspec-2.7.4
- hspec-discover-2.7.4
- QuickCheck-2.14.2
- hspec-core-2.7.4
- random-1.2.0
- splitmix-0.1.0.3
allow-newer: true

@kazu-yamamoto
Copy link
Collaborator

Great! I made it!

@kazu-yamamoto kazu-yamamoto self-requested a review December 3, 2020 00:07
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kazu-yamamoto added a commit to kazu-yamamoto/network that referenced this pull request Dec 3, 2020
@kazu-yamamoto
Copy link
Collaborator

Merged. Thank you for your contribution!

Should I modify the constraint of the current version in Hackage?

@Bodigrim
Copy link

Bodigrim commented Dec 3, 2020

Yes, please. Thanks!

@kazu-yamamoto
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants