Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 3.1.2.4 to fix #513 #514

Merged
merged 1 commit into from Oct 7, 2021

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Oct 7, 2021

As discussed in #513 (comment) regenerating configure with autoconf-2.69 will fix build failures for cabal-3.4.0.0 on windows and unbreak CIs.

It's not a long-term fix, but gives us time to prepare the community for either 3.6+ or a bugfix release 3.4.1.0.

I'm guessing @kazu-yamamoto wants to generate the sdist tarball himself?

@Mikolaj
Copy link
Member

Mikolaj commented Oct 7, 2021

Yes, pretty please, the world is burning as we speak, CIs are failing, and this will buy cabal-install time to publish the long term solution.

@kazu-yamamoto kazu-yamamoto self-requested a review October 7, 2021 22:31
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot verity this PR by myself since I don't have Windows. The current code can be build with GHC 9.0.1 with Cabal 3.4 on Intel Mac. But I trust the contributors.

@kazu-yamamoto kazu-yamamoto merged commit e90a28a into haskell:master Oct 7, 2021
@kazu-yamamoto
Copy link
Collaborator

Merged this PR and released v3.1.2.4.
Thank you all for your discussions and contributions.
Please tell me whether or not this fix the ecosystem.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 7, 2021

@kazu-yamamoto: thank you very much. To clarify: the point is to generate the configure file with autoconf-2.69, if you can install this old version. And package this, including the new configure and upload to Hackage.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 7, 2021

We didn't do that, because we thought you'd want control over which file you release and so you'd want to generate them yourself, just as you generated them for the previous release (but using too new, broken autoconf).

@Mikolaj
Copy link
Member

Mikolaj commented Oct 7, 2021

And, unfortunately, as far as I can see, configure is not changed with respect to network-3.1.2.3, unless I'm missing something.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 7, 2021

@kazu-yamamoto: did I reach you? I don't want to spam your email inbox if not needed. :)

@kazu-yamamoto
Copy link
Collaborator

kazu-yamamoto commented Oct 7, 2021

I misunderstood that configure was regenerated by you since the diff is large. I'm sorry.

I don't have autoconf-2.69. So, could you send another PR with new configure? I will deprecate network 3.1.2.3/3.1.2.4 and release 3.1.2.5.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 7, 2021

Yes, we will prepare a full PR tomorrow (it's night in Europe right now). Before we can do that, could you please mark both network 3.1.2.3 and network 3.1.2.4 on Hackage so that CIs that use cabal don't pick it up and fail?

@kazu-yamamoto
Copy link
Collaborator

Sure!

@Mikolaj
Copy link
Member

Mikolaj commented Oct 7, 2021

Thank you so much. That's called 'Preferred versions' in the Hackage maintainer's box.

@kazu-yamamoto
Copy link
Collaborator

I deprecated 3.1.2.3 and 3.1.2.4.

@kazu-yamamoto
Copy link
Collaborator

Sorry for my bad. I'm waiting for the new PR and will try to release a new version ASAP.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 7, 2021

Now that you deprecated the two versions, only the M1-using people are affected, who can work around manually if really needed, unlike CIs. So the urgency is not so bad any more. But we'll prepare the PR, ready to merge this time.

@hasufell hasufell mentioned this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants