-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 3.1.2.5 #515
Bump to 3.1.2.5 #515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In configure
in tar.gz says: "# Generated by GNU Autoconf 2.69 for Haskell network package 3.1.2.3."
This is confusing. This should be "3.1.2.5". So, would you update the version in configure.ac
and regenerate configure
and re-create tar.gz?
00bd7ef
to
a0e5c73
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now LGTM.
I have released v3.1.2.5. I hope that this fixes everything. |
We'll let you know as soon as our CI picks up the new network package and runs with it. :) |
Success! Our CI (e.g., https://github.com/haskell/cabal/runs/3838166584) and other tests show no breakage any more for cabal, (3.4 as well as current version). That will give users time to switch to cabal 3.6.2 (almost released now) before other packages start using the broken new autoconf. @kazu-yamamoto, @Mistuke: thank you again. |
Here's my CI PR to remove the workaround that allowed this bug to sneak through: #516 |
Same as #514
@kazu-yamamoto the
configure
script is not part of this repo, so I generated the tarball and uploaded it here:7784930957807690A66EBDBE3786C5262ECB4A3F
)