Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 3.1.2.5 #515

Merged
merged 1 commit into from Oct 8, 2021
Merged

Bump to 3.1.2.5 #515

merged 1 commit into from Oct 8, 2021

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Oct 8, 2021

Same as #514

@kazu-yamamoto the configure script is not part of this repo, so I generated the tarball and uploaded it here:

@kazu-yamamoto kazu-yamamoto self-requested a review October 8, 2021 08:44
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In configure in tar.gz says: "# Generated by GNU Autoconf 2.69 for Haskell network package 3.1.2.3."

This is confusing. This should be "3.1.2.5". So, would you update the version in configure.ac and regenerate configure and re-create tar.gz?

@hasufell
Copy link
Member Author

hasufell commented Oct 8, 2021

@Mikolaj
Copy link
Member

Mikolaj commented Oct 8, 2021

LGTM

@kazu-yamamoto kazu-yamamoto self-requested a review October 8, 2021 09:37
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM.

@kazu-yamamoto kazu-yamamoto merged commit f2254a1 into haskell:master Oct 8, 2021
@kazu-yamamoto
Copy link
Collaborator

I have released v3.1.2.5. I hope that this fixes everything.
Thank you all for your contributions!

@Mikolaj
Copy link
Member

Mikolaj commented Oct 8, 2021

We'll let you know as soon as our CI picks up the new network package and runs with it. :)

@Mikolaj
Copy link
Member

Mikolaj commented Oct 8, 2021

Success! Our CI (e.g., https://github.com/haskell/cabal/runs/3838166584) and other tests show no breakage any more for cabal, (3.4 as well as current version). That will give users time to switch to cabal 3.6.2 (almost released now) before other packages start using the broken new autoconf.

@kazu-yamamoto, @Mistuke: thank you again.

@hasufell
Copy link
Member Author

hasufell commented Oct 8, 2021

Here's my CI PR to remove the workaround that allowed this bug to sneak through: #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants